Review Request 110685: Make it possible to hide some plugins from the context menu unless explicitly enabled by the user

[Frank Reininghaus]

> On May 28, 2013, 7:57 a.m., Kai Uwe Broulik wrote:
> > Can't the menu be lazy-initialized (and/or moved to the Actions menu so you don't accidentally hover it), so only when the user explicitly goes to the Activities menu, its content is loaded?

This is not possible using the KAbstractFileItemAction API, at least not without (probably very ugly and bug-prone) hacks: http://api.kde.org/4.10-api/kdelibs-apidocs/kio/html/classKAbstractFileItemActionPlugin.html

Please discuss any other ideas to improve the plugin with Ivan. All I'm trying to achieve here is that I and some other people don't have to waste their time triaging bugs and providing user support for that plugin any more, and that the plugin stops to make Dolphin look bad by making the app freeze for users who don't use Activities at all.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110685/#review33266
-----------------------------------------------------------


On May 28, 2013, 3:57 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110685/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 3:57 a.m.)
> 
> 
> Review request for Dolphin and David Faure.
> 
> 
> Description
> -------
> 
> The KActivities plugin has been causing some trouble recently, see https://bugs.kde.org/show_bug.cgi?id=314575 . It can block the host application when the user tries to open the context menu.
> 
> Rather than simply banning this plugin, which uses the KAbstractFileItemAction API for things that it has IMHO not been designed for, from the context menu, I am proposing a compromise that at least only shows it in the context menu if it has been explicitly enabled by the user.
> 
> Depends on https://git.reviewboard.kde.org/r/110625/ and https://git.reviewboard.kde.org/r/110684/
> 
> 
> This addresses bug 314575.
>     http://bugs.kde.org/show_bug.cgi?id=314575
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.cpp cddcc89 
>   dolphin/src/settings/services/servicessettingspage.cpp 48e816b 
>   lib/konq/konq_popupmenu.cpp f9639d8 
> 
> Diff: http://git.reviewboard.kde.org/r/110685/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130528/ddd36a3a/attachment.htm>