Review Request 110685: Make it possible to hide some plugins from the context menu unless explicitly enabled by the user

Commit Hook null at kde.org
Wed May 29 06:50:57 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110685/
-----------------------------------------------------------

(Updated May 29, 2013, 5:50 a.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and David Faure.


Description
-------

The KActivities plugin has been causing some trouble recently, see https://bugs.kde.org/show_bug.cgi?id=314575 . It can block the host application when the user tries to open the context menu.

Rather than simply banning this plugin, which uses the KAbstractFileItemAction API for things that it has IMHO not been designed for, from the context menu, I am proposing a compromise that at least only shows it in the context menu if it has been explicitly enabled by the user.

Depends on https://git.reviewboard.kde.org/r/110625/ and https://git.reviewboard.kde.org/r/110684/


This addresses bug 314575.
    http://bugs.kde.org/show_bug.cgi?id=314575


Diffs
-----

  dolphin/src/dolphincontextmenu.cpp cddcc89 
  dolphin/src/settings/services/servicessettingspage.cpp 48e816b 
  lib/konq/konq_popupmenu.cpp f9639d8 

Diff: http://git.reviewboard.kde.org/r/110685/diff/


Testing
-------

Works for me.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130529/8986ea72/attachment.htm>


More information about the kfm-devel mailing list