Review Request 111396: No more unknown icons

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111396/#review35877
-----------------------------------------------------------


This review has been submitted with commit 3c6d331abba7b36ce1aea607bd6ea35595e4fd0c by Frank Reininghaus to branch KDE/4.11.

- Commit Hook


On July 10, 2013, 7:04 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111396/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 7:04 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> A disadvantage of my recent changes in KFileItemModelRolesUpdater is that one can actually see "unknown" icons when scrolling quickly to another part of the view in directories with many items. I tried to minimize the risk that this happens by spending some time (of the 200 ms which we always accept for synchronous updates) for loading icons of all items without determining the mime type. But in directories with many items, this is not enough.
> 
> Maybe it's better to just load icons for items which do not have an icon yet on demand, i.e., just before the widget is shown on the screen. After David's recent improvements in KFileItem, KFileIcon::iconName() should be fast enough.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemlistview.h d795c96 
>   dolphin/src/kitemviews/kfileitemlistview.cpp 70ce11b 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h 20ce21c 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp eaaab6b 
> 
> Diff: http://git.reviewboard.kde.org/r/111396/diff/
> 
> 
> Testing
> -------
> 
> I never see unknown icons any more, and the performance still feels similar. If anyone sees regressions with this commit, please let me know!
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130712/6f73aca9/attachment.htm>