Review Request 111396: No more unknown icons

[Frank Reininghaus]

> On July 10, 2013, 5:26 p.m., Mark Gaiser wrote:
> > My first Ship it ever :) I gladly give it to a patch this neat!
> > 
> > I just tested it on some massive folders, a network drive and an ftp location. It all works very well and really gives me a much smoother file browsing experience then ever before with Dolphin! This patch is certainly not "the" patch that gives me that impression, but one of "the" patches. Those together are truly awesome!
> 
> Emmanuel Pescosta wrote:
>     Sry for the late response/testing :(
>     
>     Also a "Ship it" from my side! ;)
>     No regression found so far.

Thanks for the testing and for the nice comments :-)


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111396/#review35846
-----------------------------------------------------------


On July 10, 2013, 7:04 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111396/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 7:04 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> A disadvantage of my recent changes in KFileItemModelRolesUpdater is that one can actually see "unknown" icons when scrolling quickly to another part of the view in directories with many items. I tried to minimize the risk that this happens by spending some time (of the 200 ms which we always accept for synchronous updates) for loading icons of all items without determining the mime type. But in directories with many items, this is not enough.
> 
> Maybe it's better to just load icons for items which do not have an icon yet on demand, i.e., just before the widget is shown on the screen. After David's recent improvements in KFileItem, KFileIcon::iconName() should be fast enough.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemlistview.h d795c96 
>   dolphin/src/kitemviews/kfileitemlistview.cpp 70ce11b 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h 20ce21c 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp eaaab6b 
> 
> Diff: http://git.reviewboard.kde.org/r/111396/diff/
> 
> 
> Testing
> -------
> 
> I never see unknown icons any more, and the performance still feels similar. If anyone sees regressions with this commit, please let me know!
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130712/751f86d9/attachment.htm>