Review Request 111396: No more unknown icons

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111396/
-----------------------------------------------------------

(Updated July 12, 2013, 6:34 a.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

A disadvantage of my recent changes in KFileItemModelRolesUpdater is that one can actually see "unknown" icons when scrolling quickly to another part of the view in directories with many items. I tried to minimize the risk that this happens by spending some time (of the 200 ms which we always accept for synchronous updates) for loading icons of all items without determining the mime type. But in directories with many items, this is not enough.

Maybe it's better to just load icons for items which do not have an icon yet on demand, i.e., just before the widget is shown on the screen. After David's recent improvements in KFileItem, KFileIcon::iconName() should be fast enough.


Diffs
-----

  dolphin/src/kitemviews/kfileitemlistview.h d795c96 
  dolphin/src/kitemviews/kfileitemlistview.cpp 70ce11b 
  dolphin/src/kitemviews/kfileitemmodelrolesupdater.h 20ce21c 
  dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp eaaab6b 

Diff: http://git.reviewboard.kde.org/r/111396/diff/


Testing
-------

I never see unknown icons any more, and the performance still feels similar. If anyone sees regressions with this commit, please let me know!


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130712/394d4227/attachment.htm>