Review Request: Some speed improvements in KFileItemModelRolesUpdater

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106577/
-----------------------------------------------------------

(Updated Sept. 26, 2012, 3:58 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Made changes according to Franks suggestions.


Description
-------

Some speed improvements in KFileItemModelRolesUpdater (see KCachegrind screenshots - example sortAndResolvePendingRoles):
- Use QSet.erase() instead of QSet.remove() => no expensive Rehashing 
- Get rid of += in sortAndResolvePendingRoles() 
- Some other small changes


Diffs (updated)
-----

  dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 6dba224 

Diff: http://git.reviewboard.kde.org/r/106577/diff/


Testing
-------


Screenshots
-----------

Dolphin Git Master without patch
  http://git.reviewboard.kde.org/r/106577/s/734/
Dolphin Git Master with patch
  http://git.reviewboard.kde.org/r/106577/s/735/


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120926/567bf0eb/attachment.htm>