Review Request: Some speed improvements in KFileItemModelRolesUpdater

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106577/#review19483
-----------------------------------------------------------

Ship it!


Thanks, looks great! Please push to master after reverting the small formatting change I've pointed out below.


dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp
<http://git.reviewboard.kde.org/r/106577/#comment15414>

    This change isn't really needed, please revert it. When examining the git history at some later point to understand what happened, it's best if the commit only contains changes that are related to the bug fix/new feature/performance improvement.


- Frank Reininghaus


On Sept. 26, 2012, 3:58 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106577/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2012, 3:58 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Some speed improvements in KFileItemModelRolesUpdater (see KCachegrind screenshots - example sortAndResolvePendingRoles):
> - Use QSet.erase() instead of QSet.remove() => no expensive Rehashing 
> - Get rid of += in sortAndResolvePendingRoles() 
> - Some other small changes
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 6dba224 
> 
> Diff: http://git.reviewboard.kde.org/r/106577/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Dolphin Git Master without patch
>   http://git.reviewboard.kde.org/r/106577/s/734/
> Dolphin Git Master with patch
>   http://git.reviewboard.kde.org/r/106577/s/735/
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120927/ebab872f/attachment.htm>