Review Request: Some speed improvements in KFileItemModelRolesUpdater

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106577/#review19441
-----------------------------------------------------------


- Frank Reininghaus


On Sept. 25, 2012, 9:07 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106577/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2012, 9:07 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Some speed improvements in KFileItemModelRolesUpdater (see KCachegrind screenshots - example sortAndResolvePendingRoles):
> - Use QSet.erase() instead of QSet.remove() => no expensive Rehashing 
> - Get rid of += in sortAndResolvePendingRoles() 
> - Some other small changes
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h cabb003 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 6dba224 
> 
> Diff: http://git.reviewboard.kde.org/r/106577/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Dolphin Git Master without patch
>   http://git.reviewboard.kde.org/r/106577/s/734/
> Dolphin Git Master with patch
>   http://git.reviewboard.kde.org/r/106577/s/735/
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120926/181aa2b9/attachment.htm>