Review Request: Improving the Accessibility Interface for Dolphin

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106555/#review19406
-----------------------------------------------------------

Ship it!


Thanks for the explanations and the new patch! I agree that the assert should better be removed then.

I have two more little comments on whitespace issues. Feel free to push this ater fixing them, no review request-update needed.


dolphin/src/kitemviews/kitemlistviewaccessible.cpp
<http://git.reviewboard.kde.org/r/106555/#comment15347>

    Add a space between 'if' and '('.



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
<http://git.reviewboard.kde.org/r/106555/#comment15348>

    Dolphin coding style:
    
    } else {


- Frank Reininghaus


On Sept. 24, 2012, 10:23 p.m., Amandeep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106555/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2012, 10:23 p.m.)
> 
> 
> Review request for Dolphin, Frederik Gladhorn and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Hi Frank. Sorry for unintended damage. I have removed the layouter function from public in this diff. Also had to make other changes to make the AccessibleInterface work with Orca as well.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.cpp 580cf5b 
>   dolphin/src/kitemviews/kitemlistviewaccessible.cpp 6ca9cc8 
>   dolphin/src/kitemviews/kitemlistview.h 2c30c6f 
> 
> Diff: http://git.reviewboard.kde.org/r/106555/diff/
> 
> 
> Testing
> -------
> 
> Tried it with Orca and KMag
> 
> 
> Thanks,
> 
> Amandeep Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120925/52f62c11/attachment.htm>