Review Request: Improving the Accessibility Interface for Dolphin

[Frederik Gladhorn]

> On Sept. 24, 2012, 9:26 p.m., Frank Reininghaus wrote:
> > dolphin/src/kitemviews/kitemlistviewaccessible.cpp, line 36
> > <http://git.reviewboard.kde.org/r/106555/diff/1/?file=86949#file86949line36>
> >
> >     Why is the assert not valid any more?

This assert was added by me for debugging purposes since we had the calculation of cell indices wrong for a while. I agree that it's valid. The problem is that when dealing with the accessibility frameworks we communicate over DBus and a screen-reader or other tool might end up trying to access an invalid index sometimes. This can happen when the information is outdated (eg right after switching a directory), so eventually we will end up making a call that would then crash dolphin. I initially put lots of asserts into the qt-at-spi plugin that enables the DBus communication, but it ends up being very crash prone, which is why it's mostly switched to warning about issues and not asserting any more. We have several tools accessing these interfaces - for example Orca (which really works better with Dolphin than I imagined possible in such a short time now), Simon (at least it's in the works), KMag and potentially others.
Thanks for caring so much, it's great to get your feedback!


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106555/#review19396
-----------------------------------------------------------


On Sept. 24, 2012, 8:03 a.m., Amandeep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106555/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2012, 8:03 a.m.)
> 
> 
> Review request for Dolphin, Frederik Gladhorn and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Hi Frank. Sorry for unintended damage. I have removed the layouter function from public in this diff. Also had to make other changes to make the AccessibleInterface work with Orca as well.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.h 2c30c6f 
>   dolphin/src/kitemviews/kitemlistview.cpp 580cf5b 
>   dolphin/src/kitemviews/kitemlistviewaccessible.cpp 6ca9cc8 
> 
> Diff: http://git.reviewboard.kde.org/r/106555/diff/
> 
> 
> Testing
> -------
> 
> Tried it with Orca and KMag
> 
> 
> Thanks,
> 
> Amandeep Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120924/30b6a3a3/attachment.htm>