Review Request: Improving the Accessibility Interface for Dolphin

[Frank Reininghaus]

> On Sept. 25, 2012, 6:40 a.m., Frank Reininghaus wrote:
> > Thanks for the explanations and the new patch! I agree that the assert should better be removed then.
> > 
> > I have two more little comments on whitespace issues. Feel free to push this ater fixing them, no review request-update needed.

Ah, I should better read all new mails before replying ;-) I see that you pushed the change already. This is fine, of course. Don't worry about the coding style issues in the code that's already in the repository then (I just thought that it makes sense to consider the coding style in any lines you add or change in the scope of this review request before pushing). There are probably more of these in the new classes - I'll go through the code and fix them myself when I have nothing else to do. That's more efficient than pointing out the issues to you and then having you fix them, I guess.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106555/#review19406
-----------------------------------------------------------


On Sept. 24, 2012, 10:23 p.m., Amandeep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106555/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2012, 10:23 p.m.)
> 
> 
> Review request for Dolphin, Frederik Gladhorn and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Hi Frank. Sorry for unintended damage. I have removed the layouter function from public in this diff. Also had to make other changes to make the AccessibleInterface work with Orca as well.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.cpp 580cf5b 
>   dolphin/src/kitemviews/kitemlistviewaccessible.cpp 6ca9cc8 
>   dolphin/src/kitemviews/kitemlistview.h 2c30c6f 
> 
> Diff: http://git.reviewboard.kde.org/r/106555/diff/
> 
> 
> Testing
> -------
> 
> Tried it with Orca and KMag
> 
> 
> Thanks,
> 
> Amandeep Singh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120925/216447a5/attachment.htm>