Review Request: Fix for bug 300248

Panos Kanavos panos.knvs at gmail.com
Wed Sep 5 11:09:25 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106325/
-----------------------------------------------------------

(Updated Sept. 5, 2012, 10:09 a.m.)


Review request for Dolphin.


Changes
-------

OK, here is a new version, that adds both an the arrow icon and the text. I also changed the condition to set the icon's text to be consistent with the other conditionals in the function.


Description
-------

Provides a possible improvement to Dolphin's additional search criteria button, according to the request in https://bugs.kde.org/show_bug.cgi?id=300248.


Diffs (updated)
-----

  dolphin/src/search/dolphinsearchbox.h ee9987a 
  dolphin/src/search/dolphinsearchbox.cpp 28f1f1a 

Diff: http://git.reviewboard.kde.org/r/106325/diff/


Testing
-------

The modified button behaves at it should.


Thanks,

Panos Kanavos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120905/a9a542c4/attachment.htm>


More information about the kfm-devel mailing list