Review Request: Fix for bug 300248

[Panos Kanavos]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106325/
-----------------------------------------------------------

(Updated Sept. 5, 2012, 12:22 p.m.)


Review request for Dolphin.


Changes
-------

Here is another review with the changes you proposed Frank. Please have a look and if it's ok go ahead and push it.

I'd also like to try another change but I will need some help. Is there a place we can discuss this or can I just send you a mail? Since I couldn't find a relevant bug/request report for this, I'd like to try it before making it a request.


Description
-------

Provides a possible improvement to Dolphin's additional search criteria button, according to the request in https://bugs.kde.org/show_bug.cgi?id=300248.


Diffs (updated)
-----

  dolphin/src/search/dolphinsearchbox.h ee9987a 
  dolphin/src/search/dolphinsearchbox.cpp 28f1f1a 

Diff: http://git.reviewboard.kde.org/r/106325/diff/


Testing
-------

The modified button behaves at it should.


Thanks,

Panos Kanavos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120905/1760646c/attachment.htm>