Review Request: Fix for bug 300248

[Panos Kanavos]

> On Sept. 5, 2012, 8:59 a.m., Frank Reininghaus wrote:
> > Thanks for the patch!
> > 
> > About the button text: I'm not sure either what the optimal solution is. Maybe "More Options" and "Hide Options"?
> > 
> > Another thing: I was wondering if we should put both the icon and the new text on the button. Maybe this would make it more obvious that this button is different from the others? Just to make sure that noone overlooks the button at first sight.
> > 
> > @Kai: I haven't worked on any of the search-related code myself, but it seems that there is indeed not way to search for tags in the new interface. See also https://bugs.kde.org/show_bug.cgi?id=304406
> 
> Todd Jennings wrote:
>     Is the "+" icon the correct icon?  This isn't really adding something, it is expanding and contracting a hidden section.  As far as I can recall, other KDE applications use arrow-down-double and arrow-up-double for this sort of behavior (see Kate for example).
>     
>     Also, should it have a tooltip?

Adding the icon too is probably a good idea. About the tooltip, if the button has text on it, then we shouldn't add the tooltip. I also tried adding a tooltip with the icon-only button, but the problem isn't the description but making this button more obvious, so IMHO we should add the text on it. Anyway, I'll try various combinations and post them so we can choose.


- Panos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106325/#review18539
-----------------------------------------------------------


On Sept. 4, 2012, 1:27 p.m., Panos Kanavos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106325/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2012, 1:27 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Provides a possible improvement to Dolphin's additional search criteria button, according to the request in https://bugs.kde.org/show_bug.cgi?id=300248.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/search/dolphinsearchbox.h ee9987a 
>   dolphin/src/search/dolphinsearchbox.cpp 28f1f1a 
> 
> Diff: http://git.reviewboard.kde.org/r/106325/diff/
> 
> 
> Testing
> -------
> 
> The modified button behaves at it should.
> 
> 
> Thanks,
> 
> Panos Kanavos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120905/761fb7a5/attachment.htm>