Review Request: Better tab titles in dolphin when in split view mode

Peter Penz peter.penz19 at gmail.com
Sun Mar 18 11:14:16 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104305/#review11534
-----------------------------------------------------------


Thanks for helping us to improve Dolphin! But as Frank I'm also in doubt whether this should go in at all:

- The unknown dragging-target is an issue. Due to the feedback on bugs.kde.org we know that quite a few people are using the drag-feature on tabs (it was broken with Dolphin 2.0 -> not good, but at least we know now that this feature is used). Also we know that the "split-view" is enabled per default by some people, but until now it seems nobody had a trouble with the missing tab-title for the second, inactive split-view.

- I personally think this improvement gets a problem as soon as more tabs than 3 or 4 tabs are shown, as the available width of a tab decreases and it is impossible to recognize even one path of the tab.

So currently I'd tend to skip this change. Probably you'd like to discuss this topic with other people on forum.kde.org (in the Dolphin forum) to at least find out whether other people have a similar demand for this change or probably have some other ideas: E.g. I initially thought that using a more subtle color for the inactive view text in the tab might work, but tabs don't seem to support richtext... Also we might think about increasing the minimum tab-width to bypass the second issue.

- Peter Penz


On March 16, 2012, 5:24 p.m., Paul Walger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104305/
> -----------------------------------------------------------
> 
> (Updated March 16, 2012, 5:24 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Showing both locations in the tab title.
> 
> See <http://forum.kde.org/brainstorm.php#idea99434_page1>
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h c2a548906966c302a4b9183c6142b603cd5e53e5 
>   dolphin/src/dolphinmainwindow.cpp 4c551b2c39c83146bfa69a08ae3b2ab696ce8bde 
> 
> Diff: http://git.reviewboard.kde.org/r/104305/diff/
> 
> 
> Testing
> -------
> 
> Tested with split view mode as default and opening a new tab and than changing to split mode.
> 
> 
> Thanks,
> 
> Paul Walger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120318/c7362a93/attachment.htm>


More information about the kfm-devel mailing list