Review Request: fix path for storing viewpropertysettings on Windows
Patrick Spendrin
ps_ml at gmx.de
Sat Mar 17 12:59:07 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104313/
-----------------------------------------------------------
Review request for Dolphin.
Description
-------
On Windows you cannot simply concatenate two paths because the : character is forbidden except after the drive letter. The second issue I am addressing with this patch is that you use the local file name e.g. C:/kde/ which doesn't start with a / so the resulting path is something like this C:/Users/Patrick/.kde/.../localC:/kde. Theoretically using KUrl::path() would fix that, but that doesn't work for the rest of the code.
I know that the patch is a bit ugly, if you can think of a better solution, please just let me know.
This addresses bug 287360.
http://bugs.kde.org/show_bug.cgi?id=287360
Diffs
-----
dolphin/src/views/viewproperties.cpp 36ec6bd
Diff: http://git.reviewboard.kde.org/r/104313/diff/
Testing
-------
Windows only, the bug 287360 is fixed.
Thanks,
Patrick Spendrin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120317/10036adf/attachment.htm>
More information about the kfm-devel
mailing list