Review Request: Better tab titles in dolphin when in split view mode

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104305/#review11511
-----------------------------------------------------------


Thanks for the patch!

One the one hand, I think that this might be a nice idea - makes it clear at first sight what is going on in each tab when you have many tabs open :-) However, if you drag a file and drop it on a tab which shows two folder names, you don't know to which of them it will be copied/moved, which makes me think that the tab title must clearly show which folder is open in the "active view container" of that tab.

Code-wise, it might be better to factor out the code which is repeated three times to a new function QString DolphinMainWindow::activeTabText() or something like that. But please wait for Peter's feedback before you start working on this (I think that Peter has some plans to move the tab-handling related code of DolphinMainWindow to a new class anyway).

- Frank Reininghaus


On March 16, 2012, 5:24 p.m., Paul Walger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104305/
> -----------------------------------------------------------
> 
> (Updated March 16, 2012, 5:24 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Showing both locations in the tab title.
> 
> See <http://forum.kde.org/brainstorm.php#idea99434_page1>
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h c2a548906966c302a4b9183c6142b603cd5e53e5 
>   dolphin/src/dolphinmainwindow.cpp 4c551b2c39c83146bfa69a08ae3b2ab696ce8bde 
> 
> Diff: http://git.reviewboard.kde.org/r/104305/diff/
> 
> 
> Testing
> -------
> 
> Tested with split view mode as default and opening a new tab and than changing to split mode.
> 
> 
> Thanks,
> 
> Paul Walger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120317/05d1e508/attachment.htm>