Dolphin change proposals

[Peter Penz]

Hi Todd,

On Friday 29 January 2010 21:45:38 todd rme wrote:
> I am having a bit of trouble with the group selection.  So far I have
> gotten most things to work.  However, there is one issue I can't
> figure out.  Whenever I click the header of the group (the category
> drawer as it is called), it immediately deselects all the the
> previously-selected items.  If I ctrl+click, it doesn't.  I can't
> figure out what function is triggering the deselection, though.  I
> thought it would be in mousepressevent, but I put a kdebug check at
> the beginning of the function and it is reporting that the items are
> already deselected by the time mousepressevent is being called.  I
> tried putting tests at the beginning and end of various functions to
> see if the selection status changes over the course of the function,
> but none of the ones I tried seem to work. 

Did you test KCategorizedView encapsulated in a custom application or did you 
use Dolphin? If you used Dolphin: The DolphinIconsView is derived from 
KCategorizedView and clears the selection in 
DolphinIconsView::mousePressEvent() if no valid index has been reached by the 
mouse press event. The reason for the clearing is, that (at least this was the 
case with Qt 4.4...) when clicking on the viewport below the last visible row, 
no clearing of the selection had been done. Maybe this has been solved already 
in Qt and the code can be removed...

> I can put something in
> paintevent to store the values, but this would require either saving a
> list of selected items or doing a comparison between the currently
> selected items and a second list any time you even move the mouse over
> a file, which doesn't seem to be a good approach.  

Doing something different than painting when receiving the paint event, cries 
for problems... Please don't do it :-) 

> Does anyone have
> any idea where this deselection is being trigger so I can circumvent
> it?  Alternatively, a way to only trigger the change on paintevent
> when someone changes the selection status of a file would work as
> well.
> 
> While I am on the subject, I plan to make a copy of the list of
> selected items before the deselection occurs and then restoring that
> list if the user ends up clicking on a category drawer.  I know this
> is an ineffecient approach, but the only alternative I have been able
> to come up with is to not allow people to start a rubber band
> rectangle inside a category drawer, and that seems even worse
> (although I could do it if people really think it is important).  Both
> approaches, however require that I figure out what is triggering the
> deselection.
> 
> On Wed, Jan 13, 2010 at 12:25 PM, todd rme <toddrme2178 at gmail.com> wrote:
> > I've started on trying to fix the group selection bug.  While I'm on
> > the subject, is there a reason the the line along the left edge of the
> > group no longer streches across the whole height of the group, or is
> > that another bug introduced by the refactoring of kcategoryizedview?
> > If it is I might as well fix it while I am at it.
> >
> > -Todd
> >
> > On Mon, Jan 11, 2010 at 1:20 PM, Aaron J. Seigo <aseigo at kde.org> wrote:
> >> On January 10, 2010, todd rme wrote:
> >>> And maybe an actions panel, which show the "actions" right-click menu
> >>> in a dockable panel for easier access and improved visibility.  It
> >>> wouldn't be present by default, but I think would be good to have
> >>> available.
> >>
> >> it does work nicely in gwenview, i think :)
> >>
> >>> I would like some feedback on which these ideas (if any) people think
> >>> are good and should be implemented or if there are any suggestions.  I
> >>> can't guarantee that I will be able to implement any of these, but I
> >>> will at least try if people think they are worthwhile.
> >>
> >> obviously Peter and David will have to weigh in on this as they are the
> >> maintainers of various pieces of the code you'll be working on, but i
> >> think all of the fixes/features you mention would be very worthwhile and
> >> would raise the level of polish in Dolphin. :)
> >>
> >> --
> >> Aaron J. Seigo
> >> humru othro a kohnu se
> >> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
> >>
> >> KDE core developer sponsored by Qt Development Frameworks
>