Adblock Plugin

[Leo Savernik]

Am Dienstag, 7. Juli 2009 schrieb Jonathan Marten:
> Is this the appropriate list to ask about or post patches for the
> adblock plugin (currently in KDE4 extragear)?

Yes. Additionally you can try to ask the maintainers of the adblock-plugin for 
review.
>
> I've found this plugin very useful for a long time, but feel that it
> could do with some attention.  In particular, making it possible to
> add more than one entry at a time from the "Blockable items" dialogue,
> update the list of blocked items as filters are added there, and allow
> blocking of iframe's.  I've already implemented these and find the
> blocker a lot more usable, should I post the patch here before
> committing?

Excellent. Just post the patch on this list and wait for comments. I'm not 
involved in the adblock code so I can't give you clearance. But I'll try to 
review the khtml-specific parts if time permits. If nobody objects within, 
say, two weeks from today, commit anyways.

Be aware that after having committed, you take the responsibility to fix bugs 
and regressions caused by your commits.
>
> There are some other adblock bugs that I'd like to address,
> https://bugs.kde.org/show_bug.cgi?id=189563 (default button action in
> the KCM) and https://bugs.kde.org/show_bug.cgi?id=150934 (show which
> filters have caused an item to be blocked).  The second of these would
> be extremely useful, and I've already prototyped a tooltip GUI for it,
> but getting the matched filter information would need some additions
> to KHTMLSettings which would need care to remain BC.

Yes, please go ahead! Any improvement to the adblock-plugin is wholeheartedly 
welcome.

mfg
	Leo