Adblock Plugin

[Marcus Harrison]

The usual practice is to attach patches here for review before having them 
committed, so I would do that. If the patches work and don't break anything 
else, it's usually just a case of the reviewing developer giving it a nod and 
merging it into trunk.

On Tuesday 07 July 2009 12:46:48 Jonathan Marten wrote:
> Dear all,
>
> Is this the appropriate list to ask about or post patches for the
> adblock plugin (currently in KDE4 extragear)?
>
> I've found this plugin very useful for a long time, but feel that it
> could do with some attention.  In particular, making it possible to
> add more than one entry at a time from the "Blockable items" dialogue,
> update the list of blocked items as filters are added there, and allow
> blocking of iframe's.  I've already implemented these and find the
> blocker a lot more usable, should I post the patch here before
> committing?
>
> There are some other adblock bugs that I'd like to address,
> https://bugs.kde.org/show_bug.cgi?id=189563 (default button action in
> the KCM) and https://bugs.kde.org/show_bug.cgi?id=150934 (show which
> filters have caused an item to be blocked).  The second of these would
> be extremely useful, and I've already prototyped a tooltip GUI for it,
> but getting the matched filter information would need some additions
> to KHTMLSettings which would need care to remain BC.
>
> Regards,
>   Jonathan
-- 
Marcus Harrison. Juggler, unicycler, website designer, potential software 
developer, author, book enthusiast, philosopher, quantum theorist, skate-
boarder, goth, cellist. I have no professions.