[PATCH]Konqueror File Manager icons.

[James Richard Tyrer]

David Faure wrote:
> Hello,
> 
> please don't mix icon fixes with behavior changes, they are rather different
> things.
> 
OK, will post separate thread for adding KFM to the menu.

> On Sunday 21 December 2008, James Richard Tyrer wrote:
>> +++ kfmclient.desktop   (working copy)
>> @@ -2,7 +2,7 @@
>>  # This desktop file is the one used by KApplication::invokeBrowser
>>  Type=Application
>>  Exec=kfmclient openURL %u
>> -Icon=konqueror
>> +Icon=system-file-manager-kfm
> 
> This is wrong because invokeBrowser is about opening a webbrowser,
> not a file manager. See k-c-d thread about the invokeBrowser implementation
> recently. I detected one wrong usage of invokeBrowser where a filemanager
> was intended, this is still to be fixed (and I forgot where it was now ;).
> 
>> +# This desktop file is the one used by KApplication::invokeBrowser
>> +Exec=kfmclient openProfile filemanagement
> 
> Doesn't make sense either, for the same reason.
> 
Yes, I needed to remove that.  Must have used the wrong file.  I have 
very poor concentration due to illness.  My apologies and also my thanks 
for catching my omission.

OK, my thought was that 'desktop' files that execute: "kfmclient" should 
all have the KFM icon (system-file-manager-kfm).  While this seems 
logical to me -- KFM does stand for Konqueor File Manager, there are 
other possible criteria.  There are 4 'desktop' files in question:

	kfmclient.desktop
	kfmclient_dir.desktop
	kfmclient_html.desktop
	kfmclient_war.desktop

The first one, "kfmclient.desktop" will open any URL and appears to 
select the Profile based on the URL.  So, this should have the Browser icon.

The second "kfmclient_dir.desktop", IIUC, is to open a directory, so 
this should have the KFM icon.

The third one "kfmclient_html.desktop" opens an HTML file.  This is 
opened in the WebBrowsing profile.  This is an issue.  Why should an 
HTML file be opened in "WebBrowsing" it unless the protocol is HTTP? 
But as it is now, that should have the Browser icon.

And the forth one "kfmclient_war" doesn't seem to work.  However, it 
starts to open the file with the FileManagement profile so, if this is 
the way it is supposed to work, then it should have the KFM icon.

If the above is OK, I will make the changes and post a revised patch. 
Or, we can discuss it further.

The other possibility is to have an icon for the KFMClient.

-- 
JRT