[PATCH]Konqueror File Manager icons.

David Faure faure at kde.org
Mon Dec 22 17:17:42 GMT 2008


Hello,

please don't mix icon fixes with behavior changes, they are rather different
things.

On Sunday 21 December 2008, James Richard Tyrer wrote:
> +++ kfmclient.desktop   (working copy)
> @@ -2,7 +2,7 @@
>  # This desktop file is the one used by KApplication::invokeBrowser
>  Type=Application
>  Exec=kfmclient openURL %u
> -Icon=konqueror
> +Icon=system-file-manager-kfm

This is wrong because invokeBrowser is about opening a webbrowser,
not a file manager. See k-c-d thread about the invokeBrowser implementation
recently. I detected one wrong usage of invokeBrowser where a filemanager
was intended, this is still to be fixed (and I forgot where it was now ;).

> +# This desktop file is the one used by KApplication::invokeBrowser
> +Exec=kfmclient openProfile filemanagement

Doesn't make sense either, for the same reason.

-- 
David Faure, faure at kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kfm-devel mailing list