possible bugfix in KHTMLPart::findTextNext ?

[Eva Brucherseifer]

Hi,

Am Freitag, 24. Februar 2006 18:48 schrieben Sie:
> Am Donnerstag, 23. Februar 2006 18:03 schrieb Eva Brucherseifer:
> > Hi,
> >
> > the method KHTMLPart::findTextNext(..) didn't work for us in our Qt2 port
> > of Konq/E. With the attached patch the method works for us.
>
> It doesn't work because it doesn't search from the last find position then?

I talked back to Rafael, who worked on this. 
This patch actually made the function work at all (for forward & backward) 
search. Before it only was able to find the first hit, now it can find next 
hits too.

Still we have problems with the backward search. It seems to leave hits out 
when searching backwards. If you have any hint what it is, that would be 
great!

>
> > @@ -2824,7 +2834,7 @@ bool KHTMLPart::initFindNode( bool selec
> >  // Old method (its API limits the available features - remove in KDE-4)
> >  bool KHTMLPart::findTextNext( const QString &str, bool forward, bool
> > caseSensitive, bool isRegExp )
> >  {
> > -    if ( !initFindNode( false, !forward, false ) )
> > +    if ( !initFindNode( false, !forward, d->m_findNode ) )
> >        return false;
> >      while(1)
> >      {
> >
> > We think, that this bugfix might also be applicable for the Qt3/Embedded
> > and the desktop version of KDE 3.5. So someone here might want to check
> > this and apply the patch in kdelibs.
>
> The old function isn't called anywhere from within khtml, so you probably
> have uncovered a real bug.

:-))

Cheers,
eva

>
>
> mfg
> 	Leo

-- 
Eva Brucherseifer
General Manager

basysKom GmbH
Robert-Bosch-Str. 7 | 64293 Darmstadt | Germany
Tel: +49 6151 3969-961 | Fax: -736 | Mobile: +49 170 5533642
eva.brucherseifer at basyskom.de | www.basyskom.de