possible bugfix in KHTMLPart::findTextNext ?

Leo Savernik l.savernik at aon.at
Fri Feb 24 17:48:52 GMT 2006


Am Donnerstag, 23. Februar 2006 18:03 schrieb Eva Brucherseifer:
> Hi,
>
> the method KHTMLPart::findTextNext(..) didn't work for us in our Qt2 port
> of Konq/E. With the attached patch the method works for us.

It doesn't work because it doesn't search from the last find position then?
>
> @@ -2824,7 +2834,7 @@ bool KHTMLPart::initFindNode( bool selec
>  // Old method (its API limits the available features - remove in KDE-4)
>  bool KHTMLPart::findTextNext( const QString &str, bool forward, bool
> caseSensitive, bool isRegExp )
>  {
> -    if ( !initFindNode( false, !forward, false ) )
> +    if ( !initFindNode( false, !forward, d->m_findNode ) )
>        return false;
>      while(1)
>      {
>
> We think, that this bugfix might also be applicable for the Qt3/Embedded
> and the desktop version of KDE 3.5. So someone here might want to check
> this and apply the patch in kdelibs.

The old function isn't called anywhere from within khtml, so you probably have 
uncovered a real bug.
>

mfg
	Leo




More information about the kfm-devel mailing list