[PATCH] Konqueror adblock v4

Leo Savernik l.savernik at aon.at
Sun May 1 08:15:40 BST 2005


Am Sonntag, 1. Mai 2005 08:23 schrieb Ivor Hewitt:
> > Can't comment on the rendering/loader part of the patch.
>
> I changed the way the blocking works so that cacheimage sets itself to
> finished immediately rather than stopping the loading in requestImage, so
> I'd appreciate anyone with knowledge of the loader commenting on this
> method.

Erm, you render_image change leaves an unlayouted render_image whenever it is 
blocked. This is not acceptable. Furthermore, it is not acceptable that the 
renderer ignores the specifications of the document at will (i. e. if the 
<img> has a predefined width and height, the renderer must not ignore it).

If you really want to have those images take no space, you have to remove the 
<img> tag at the document level. I doubt it's worth it.

mfg
	Leo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20050501/feb18743/attachment.sig>


More information about the kfm-devel mailing list