[PATCH] Konqueror adblock v4

[Ivor Hewitt]

On Saturday 30 Apr 2005 22:55, David Faure wrote:
>
> d->m_imageURL.host() != QString::null
> is usually written as !d->m_imageURL.host().isEmpty(), which is slightly
> faster.
>
Ta. I wasn't sure if QString::null was a special case that had to be checked 
for explicitly.

> But I can make this change myself once the patch is in, if you
> want.
>
I'll update the patch anyway. I'll submit another one if I add more features.

> isKillEnabled() could have a more self-describing name. 
>
I ran out of imagination. 

> m_wasBlocked=1;
> should be true instead 1, it's a boolean.
>
Quite right.

> Can't comment on the rendering/loader part of the patch.
>
I changed the way the blocking works so that cacheimage sets itself to 
finished immediately rather than stopping the loading in requestImage, so I'd 
appreciate anyone with knowledge of the loader commenting on this method.

Thanks,

-- 
Ivor Hewitt.
http://www.ivor.it - tech | http://www.ivor.org - hedge