[PATCH] Konqueror adblock v4

[Ivor Hewitt]

On Sunday 01 May 2005 08:15, Leo Savernik wrote:
> Am Sonntag, 1. Mai 2005 08:23 schrieb Ivor Hewitt:
> > > Can't comment on the rendering/loader part of the patch.
> >
> > I changed the way the blocking works so that cacheimage sets itself to
> > finished immediately rather than stopping the loading in requestImage, so
> > I'd appreciate anyone with knowledge of the loader commenting on this
> > method.
>
> Erm, you render_image change leaves an unlayouted render_image whenever it
> is blocked. This is not acceptable. Furthermore, it is not acceptable that
> the renderer ignores the specifications of the document at will (i. e. if
> the <img> has a predefined width and height, the renderer must not ignore
> it).
>
That was intentional. Are you saying it is unacceptable from a technical or an 
aesthetic point of view.
The layout is only ignored if the option of completely stripping the ad is 
specified by the user. i.e. is it unacceptable to break the layout if the 
user asks for it to be broken?

> If you really want to have those images take no space, you have to remove
> the <img> tag at the document level. I doubt it's worth it.
>
I'll look into that.

-- 
Ivor Hewitt.
http://www.ivor.it - tech | http://www.ivor.org - hedge