[PATCH] Konqueror adblock v4

Martijn Klingens klingens at kde.org
Sun May 1 00:38:49 BST 2005


On Saturday 30 April 2005 23:55, David Faure wrote:
> isKillEnabled() could have a more self-describing name. Think of someone
> reading the KHTML source code without having followed this thread, how
> could he guess what "killing" is about here? :)
> Not that I have anything to suggest; isRemoveFilteredEnabled is a bit long
> :)

What about isHideAdsEnabled() ?

Also, as for describing names, if I understand the thread correct this code 
filters just ads, so why not rename d->filters to d->adFilters and 
m_filterEnabled to m_adFilterEnabled? ("filter" is quite a generic term, 
which can be confusing in bigger codebases like this.)

Likewise, I'd call the config group "AdFilter Settings" or so.

No comments from me on the code itself, just the variable naming :)

-- 
Martijn




More information about the kfm-devel mailing list