MMB on Back/Forward/Up/Home Toolbar and Go menu

[Leo Savernik]

Am Freitag, 14. Januar 2005 06:38 schrieb Daniel Teske:
> > There's only one little issue left (sorry, but this is really the last
> > one, promised ;-) ): Honor "NewTabsInFront"-setting. I. e. if true, new
> > tab should be opened in the foreground (as currently is), otherwise in
> > the background (as I have set it).
>
> Fixed, as everywhere else SHIFT negates NewTabsInFront.

Excellent!
>
> There is one thing, where I don't know if the behaviour is correct:
> MMB/Ctrl+Left on the Home toolbar button ignores openAfterCurrentPage,
> the new tab is always at right end.
> This mirrows the addTab and MMB on Bookmark entry behaviour.
> And differs from the Forward/Back and Up toolbar buttons.

I have no opinion here. Leave it as is.
>
> And I throughly tested that everything works.

I tested your patch, too, and everything works now as expected. See my review 
below.

>
[...]

Review: 
[...]
> +void KonqMainWindow::openFilteredURL( const QString & _url, const 
KonqOpenURLRequest _req)

should be "const KonqOpenURLRequest &_req"
(note the &).
>  {
[...]
> +    req.newTabInFront = config->readBoolEntry( "NewTabsInFront", false ) 
xor bool(state & Qt::ShiftButton);

Please don't use C99 features in C++. Use ^ instead of xor. Please fix all 
occurrances.
> +
[...]
> +  /**
> +   * Filters the URL and calls the main openURL method.
> +   */
> +  void openFilteredURL( const QString & _url, const KonqOpenURLRequest 
_req);

Here also & is missing.

> +
[...]


Now that we have David's OK and coolo's blessing, your fixed patch should go 
in soon.

mfg
 Leo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20050114/bdd43c84/attachment.sig>