Fwd: [PATCH] Bug 58580 - Konqueror sidebar settings not stored in profile

[Andre Moreira Magalhaes]

 --- David Faure <faure at kde.org> wrote: 
> So if I understand correctly, instead of saving "the open sidebar
> tab" into Konqueror's profile like before, it now saves the whole 
> set of tabs, and which one is the opened one, into 
> konqsidebartng/entries. OK.
it saves all sidebar configuration (openviews, width, tabsleft, ...) in
konqsidebarntg.rc, in a group with the name of the profile. the entries
showed in the sidebar are saved in konqsidebartng/profile_name/entries.
There is a kconf_update script that loads the old configuration.

> [I see potential for reports from users who use 20 profiles: they
> might have to change their sidebar configuration 20 times. But well, 
> that's the price of flexibility...]
i still believe that it could be necessary go with predefined sidebars.
for ex.: i believe webbrowsing doesn't need a root folder/home folder,
.... This could be done, just verifying in the initialCopy if there is
a dir with the name of the profile in
$(kdedir)/share/apps/konqsidebartng/profile_name/entries. If the dir
exists copy it otherwise copy the system default
$(kdedir)/share/apps/konqsidebartng/entries. I believe this can be done
at least for the main profiles (filemanagement, webbrowsing). If you
agree i can code this. The only thing i'm not sure is what entry should
go in what profile.

> The only thing I'm missing from your patch is: what happens when the
> user loads another profile in Konqueror? 
i'm not sure (i can't test now, cause i'm not at home) but i almost
sure that it automatically loads the sidebar for that profile.

> Should the sidebar stay as it is, or should it switch accordingly?
> If the latter, well, I guess a custom event is needed
> (a bit like KonqConfigEvent, but one that means "the current profile
> has changed").
i believe that it should switch accordingly, and i believe that is
already the case.

> This is for further refinement, the patch can be committed without
> this, IMHO, but it would be nice to implement this. 
ok. when i get home i will commit.

> Otherwise I think the code will lead to one profile's settings 
> override the other profile's settings, no?
no, if this is happening (i believe no), i will fix.

> Thanks for your work, very appreciated.
it's nothing

cheers
Andrunko




	
	
		
_______________________________________________________ 
Yahoo! Acesso Grátis - Internet rápida e grátis. Instale o discador agora! http://br.acesso.yahoo.com/