Fwd: [PATCH] Bug 58580 - Konqueror sidebar settings not stored in profile

[David Faure]

On Thursday 28 October 2004 07:16, Aaron Seigo wrote:
> I have fixed the bug 58580, and i would like to know what you think
> about. I really believe that the sidebar need a rewrite but anyway the
> patch fix the bug.

Per-profile settings are good - apparently that's the consensus from the recent
discussion here on kfm-devel about filemanager vs webbrowser separation.

So if I understand correctly, instead of saving "the open sidebar tab" into Konqueror's
profile like before, it now saves the whole set of tabs, and which one is the opened one,
into konqsidebartng/entries. OK.

[I see potential for reports from users who use 20 profiles: they might have to 
change their sidebar configuration 20 times. But well, that's the price of flexibility...]

The only thing I'm missing from your patch is: what happens when the user
loads another profile in Konqueror? Should the sidebar stay as it is, or should
it switch accordingly? If the latter, well, I guess a custom event is needed
(a bit like KonqConfigEvent, but one that means "the current profile has changed").
This is for further refinement, the patch can be committed without this, IMHO,
but it would be nice to implement this. Otherwise I think the code will lead
to one profile's settings override the other profile's settings, no?

Thanks for your work, very appreciated.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).