No flicker on initial creation of the tabbar

[Stephan Binner]

On Thursday 24 June 2004 14:57, Zack Rusin wrote:

> Now instead of switching between views and reperanting widgets we just
> show/hide the tabbar. Everything would be great but:

I'm a bit surprised that it works for you at all, here it only crashes:

[KCrash handler]
#7  0x40e7f4c2 in QTabBar::currentTab ()
   from /usr/src/qt-copy/lib/libqt-mt.so.3
#8  0x40e85322 in QTabWidget::currentPageIndex ()
   from /usr/src/qt-copy/lib/libqt-mt.so.3
#9  0x40e854dd in QTabWidget::currentPage ()
   from /usr/src/qt-copy/lib/libqt-mt.so.3
#10 0x4007dfb8 in KonqViewManager::duplicateTab (this=0x82746d8, tab=)
    at ../../../kde-head/kdebase/konqueror/konq_viewmgr.cc:332
#11 0x400af034 in KonqMainWindow::slotDuplicateTab (this=0x815b0000)
    at ../../../kde-head/kdebase/konqueror/konq_mainwindow.cc:2383


[KCrash handler]
#7  0x00000000 in ?? ()
#8  0x4007663e in KonqViewManager::setupView (this=0x8274608, 
    parentContainer=0x89a4374, viewFactory=@0xbfffde40, service=@0xbfffde70, 
    partServiceOffers=@0xbfffde60, appServiceOffers=@0xbfffde50, 
    serviceType=@0x41197cf0, passiveMode=false, openAfterCurrentPage=false)
    at ../../../kde-head/kdebase/konqueror/konq_viewmgr.cc:964
#9  0x40078904 in KonqViewManager::addTab (this=)
    at ../../../kde-head/kdebase/konqueror/konq_viewmgr.cc:296
#10 0x400c0503 in KonqMainWindow::slotAddTab (this=0x826d920)
    at ../../../kde-head/kdebase/konqueror/konq_mainwindow.cc:2370
#11 0x400c8dc9 in KonqMainWindow::qt_invoke (this=0x826d920, _id=)


[KCrash handler]
#7  0x40e7f4df in QTabBar::count () from /usr/src/qt-copy/lib/libqt-mt.so.3
#8  0x40e83f81 in QTabWidget::count () from /usr/src/qt-copy/lib/libqt-mt.so.3
#9  0x400797bb in KonqViewManager::loadViewProfile (this=0x8274608, 
    cfg=@0xbfffde10, filename=@0xbfffdee0, forcedURL=@0xbfffdeb0, 
    req=@0xbfffdef0, resetWindow=false)
    at ../../../kde-head/kdebase/konqueror/konq_viewmgr.cc:1048
#10 0x4007a895 in KonqViewManager::loadViewProfile (this=0x8274608, 
    path=@0x89f68b8, filename=@0xbfffdee0, forcedURL=@0xbfffdeb0, 
    req=@0xbfffdef0, resetWindow=false)
    at ../../../kde-head/kdebase/konqueror/konq_viewmgr.cc:1038
#11 0x4007aa69 in KonqViewManager::slotProfileActivated (this=0x8274608, id=)
    at qmap.h:246

From just looking at the patch, I would move reading of "AlwaysTabbedMode" 
completely to KonqFrameTabs.

> 1) there's a bug in which when creating the sidebar (F9) they keep 
> multiplying. I think I messed up the parent container relationship 
> somewhere, I'd really appreciate if someone could look at it.

I would more bet that you have to adapt the sidebar code.

Bye,
   Steve