[patch] #63348 Konqueror looses style sheets on kde.org and gentoo.org

[Germain Garand]

Le Mardi 25 Novembre 2003 21:08, Dirk Mueller a écrit :
> On Tuesday 25 November 2003 04:05, Germain Garand wrote:
> > "Default-Style" headers were indeed being granted too much privilege
> >  via m_preferredStylesheetSet...
>
> hmm? they should preselect one.. What was wrong with the code?

It's this snippet:
     if (!title.isEmpty() &&
         ( (!l->isAlternate() && sheetUsed.isEmpty()) ||
             m_preferredStylesheetSet == title))
         sheetUsed = title;

It inconditionnally select the sheet if it's == to the "Default-Style",
even if there is already a selected style in sheetUsed.

e.g: "alt4" is requested, it will be found before "alt10" (the Default-Style), 
so it get selected... but "alt10" will also be selected shortly after. 
=> end result : alt4+alt10

If "alt20" is requested, "alt10" will be found before, so "alt20" will never 
be selected, since sheetUsed is no more empty.
=>end result: alt10