[PATCH] Fix for 54209

Ravikiran Rajagopal ravi at ee.eng.ohio-state.edu
Tue Mar 25 17:07:40 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> No, it's _remove that removes. Take only, well, "takes" out of the
> collection. But this isn't relevant for an action that won't be used at all
> anyway ;)
Mea culpa.

> > > I wonder why this is done in slotPopupMenu though - those actions are
> > > created only once, in KHTMLPart::init, so it would be enough to remove
> > > them in the KHTMLImage ctor.
> >
> > That's a good point. I'll see about moving it to the constructor.

It is a little more problematic. The slot is called when XMLGUIs are merged. 
If I removed them in the constructor, I need to be sure that merging has 
already taken place, and that no new merges will take place. I am not 
familiar enough with khtml to say that both conditions will always hold true 
in the constructor. Further, the current way of doing it is more modular, and 
I think we should stick with it. Is it ok to commit it as it is?

Regards,
Ravi

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+gIzcbI8Y8y0oVXcRAtESAKCEgX7fW/7q70fKuuTd4uCjmy0icQCfXgB1
yFFpB2CQKYRbfoW5TJ2eliE=
=odwO
-----END PGP SIGNATURE-----





More information about the kfm-devel mailing list