[PATCH] Fix for 54209

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 25 March 2003 18:07, Ravikiran Rajagopal wrote:
> > > > I wonder why this is done in slotPopupMenu though - those actions are
> > > > created only once, in KHTMLPart::init, so it would be enough to remove
> > > > them in the KHTMLImage ctor.
> > >
> > > That's a good point. I'll see about moving it to the constructor.
> 
> It is a little more problematic. The slot is called when XMLGUIs are merged.

Which slot? I don't understand.
KHTMLPart::init() is called right away.... Why not delete the action right after that?

> If I removed them in the constructor, I need to be sure that merging has
> already taken place, and that no new merges will take place. 
I really don't understand the relation with GUI merging here.
We're talking about deleting an action, right after KHTMLPart created it,
and _before_ GUI merging happens.
Then it won't show up at all.

> I am not
> familiar enough with khtml to say that both conditions will always hold true
> in the constructor. Further, the current way of doing it is more modular, and
> I think we should stick with it. Is it ok to commit it as it is?
Of course it is, but this doesn't mean we can't find a better version IMHO :)

- -- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+gI/b72KcVAmwbhARAqvKAJ4mu0anXeyjx5wfKu3F5mbp+vOSiQCfUQfj
fsam79wwwLZtbaZYSDoK2FU=
=G+cU
-----END PGP SIGNATURE-----