[PATCH] Fix for 54209

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 25 March 2003 17:36, Ravikiran Rajagopal wrote:
> > OK. It's not strictly equivalent (unplugging and deleting instead of just
> > removing from collection), but the net effect should be the same - no such
> > action in khtmlimage's menus.
> 
> Actually, take() basically just deletes it. The unplugAll() is just paranoia
> on my part.

void KActionCollection::_remove( KAction* action )
{
  delete _take( action );
}

No, it's _remove that removes. Take only, well, "takes" out of the collection.
But this isn't relevant for an action that won't be used at all anyway ;)

> > I wonder why this is done in slotPopupMenu though - those actions are
> > created only once, in KHTMLPart::init, so it would be enough to remove them
> > in the KHTMLImage ctor.
> 
> That's a good point. I'll see about moving it to the constructor.

Thanks.

- -- 
David Faure -- faure at kde.org, dfaure at klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+gIbZ72KcVAmwbhARAg6RAJ9IJf47AHLtnlk8McuaCOpa1tyJMwCeMuE/
gBeJefTiRQadO9y/csQ1GrY=
=5Xj5
-----END PGP SIGNATURE-----