[PATCH] Fix for 54209

Ravikiran Rajagopal ravi at ee.eng.ohio-state.edu
Tue Mar 25 16:36:47 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> OK. It's not strictly equivalent (unplugging and deleting instead of just
> removing from collection), but the net effect should be the same - no such
> action in khtmlimage's menus.

Actually, take() basically just deletes it. The unplugAll() is just paranoia 
on my part.

> I wonder why this is done in slotPopupMenu though - those actions are
> created only once, in KHTMLPart::init, so it would be enough to remove them
> in the KHTMLImage ctor.

That's a good point. I'll see about moving it to the constructor.

Regards,
Ravi
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+gIWfbI8Y8y0oVXcRAsAZAJ9it4t1CyIGWpdu1y9/ig963gIOFwCdEy09
uQM19AoxFb3OtdCRm18Sw1c=
=Kdua
-----END PGP SIGNATURE-----





More information about the kfm-devel mailing list