[PATCH] bookmarking all tabs as folder

[Alexander Kellett]

On Mon, Jul 07, 2003 at 12:44:01AM +0200, David Faure wrote:
> On Sunday 06 July 2003 03:49, you wrote:
> > wasn't really sure about the splitting
> > off of the owner from konq_mainwindow,
> > but i don't really like the use of
> > inheritance when it doesn't provide 
> > anything extra.
>
> Well you still use inheritance :)

:)

true, but only in a small side class,
and its just to remove the need for 
a menu->setExtendedBookmarkOwner(),
oh, and it'll disappear for 4.0 :)

> > wasn't sure how to get around the need
> > for the _p.h. Njaaard suggested using
> > METAOBJECT_SOURCES = AUTO, or something
> > like that
> This only looks at .h files, not at .cpp files (if that's what you were hoping)

right. as i had thought, 
umm.. not sure what Njaard meant then... 

> _p.h is fine, although it could also have been konq_[extended]bookmarkowner.h :)

true, but its very tightly coupled with
the interface in konq_mainwindow.h and
probably has very little other ability
for reuse, so, i'd prefer to call it _p.h
anyways, i always get confused when i see
just a .h and no .cc :)

> IMHO the patch is fine, except for the "friend class" - is this just
> for the ->m_pViewManager? There's a public accessor IIRC.

ah. true. okay. made that change now. 
i'll commit on monday. 

thanks for the review!
Alex