[PATCH] bookmarking all tabs as folder

[David Faure]

On Sunday 06 July 2003 03:49, you wrote:
> hiya david / anyone else interested,
> 
> here's an impl of a feature that 
> several people have been requesting
> for a while now ;-)
> 
> patch is kind of intrusive. so wanted
> to let you have a look through to see
> if its the best way of going about it.
> wasn't really sure about the splitting
> off of the owner from konq_mainwindow,
> but i don't really like the use of
> inheritance when it doesn't provide 
> anything extra.
Well you still use inheritance :)

> wasn't sure how to get around the need
> for the _p.h. Njaaard suggested using
> METAOBJECT_SOURCES = AUTO, or something
> like that
This only looks at .h files, not at .cpp files (if that's what you were hoping)

> , but i couldn't get that working 
> in the end so i just wound up with using
> the old faithful _p.h trick. having the
> private class in konq_mainwindow.h is
> possible of course, but horrible for
> compilation times.
_p.h is fine, although it could also have been konq_[extended]bookmarkowner.h :)

IMHO the patch is fine, except for the "friend class" - is this just
for the ->m_pViewManager? There's a public accessor IIRC.

-- 
David FAURE, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
Qtella users - stability patches at http://blackie.dk/~dfaure/qtella.html