[david at mandrakesoft.com: Re: Fwd: [patch] Re: kdelibs/khtml/dom]

Rob Kaper cap at capsi.com
Fri Nov 8 10:18:43 GMT 2002


Argh, this was supposed to go to kfm-devel.

Dirk?

On Friday 08 November 2002 10:23, you wrote:
> On Thu, Nov 07, 2002 at 12:16:51PM +0100, Rob Kaper wrote:
> > > IMHO QColor color() should be readded too (possibly in addition to rgbColor(),
> > > for source and binary compatibility.
> > 
> > http://kdewebcvs.pandmservices.com/cgi-bin/cvsweb.cgi/kdelibs/khtml/dom/css_value.cpp
> > (1.20)
> 
> Would it be safe to replace the removed
> 
> 	const QColor &color() const { return m_color; }
> with
> 	const QColor &color() const { return QColor(m_color); }
> 
> (m_color being a QRgb) ?? I don't feel like breaking khtml ;-) but color()
> should never have been removed in the first place.

Hey, hey, don't ask me, this is Dirk's change.

But AFAIK, yes, this would be safe.

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/

-- 
Rob Kaper     | Gimme some love, gimme some skin,
cap at capsi.com | if we ain't got that then we ain't got much
www.capsi.com | and we ain't got nothing, nothing! -- "Nothing" by A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20021108/e34bc3dc/attachment.sig>


More information about the kfm-devel mailing list