[patch] for per-domain settings

[Leo Savernik]

Am Sonntag, 3. November 2002 19:36 schrieb David Faure:
> On Sunday 20 October 2002 22:01, Leo Savernik wrote:
> > http://bugs.kde.org/attachment.cgi?id=229&action=view
> > first patch, khtml side only
>
> Looks quite good to me.
>
> Note that you can use k_funcinfo instead of __PRETTY_FUNCTION__, it's
> the portable version of it.

Thanks, I didn't know about k_funcinfo. But I intend to remove all those debug 
outputs in the final version nonetheless.
>
> > A little problem are the bitfields in KPerDomainSettings. g++ insists
> > that bitfields are signed, thus returning -1 for 3 in
> > KJSWindowOpenPolicy, for example. I inserted a small hack to circumvent
> > this (the other locations happen
> > to work fine because I always test for equality to 0). If anyone has a
> > cleaner idea, please tell me.
>
> Well it treats them as signed because your enum _is_ signed (it has a -1
> value). If the -1 value (inherit) can't be in the KPerDomainSettings class,
> maybe it shouldn't be in the enums at all? I'm not sure how Inherit is used
> in fact....

Inherit isn't used by anything within khtml, but it'll be needed by the 
kcontrol module (which I haven't even started yet). Coincidentally I'm 
adapting my old patch to the latest CVS, so I'll test if I get an unsigned 
enum by setting Inherit to 32767 (this is guaranteed to be positive, even for 
a 16 bit integer ;-) )
>
> > This patch is not intended to be included within KDE, and serves merely a
> > draft ready to be commented upon.
>
> Sure, it'll have to wait for after 3.1 :)

Btw, do you know how I can become the owner of bug 49145? I mean I *am* 
effectively the owner, but bugs.kde.org doesn't reflect this, and I cannot 
set myself to the owner.

mfg
	Leo

PS: no need to cc me, I'm subscribed to kfm-devel