[patch] for per-domain settings

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 20 October 2002 22:01, Leo Savernik wrote:
> http://bugs.kde.org/attachment.cgi?id=229&action=view
> first patch, khtml side only 

Looks quite good to me.

Note that you can use k_funcinfo instead of __PRETTY_FUNCTION__, it's
the portable version of it.

> A little problem are the bitfields in KPerDomainSettings. g++ insists that 
> bitfields are signed, thus returning -1 for 3 in KJSWindowOpenPolicy, for 
> example. I inserted a small hack to circumvent this (the other locations 
> happen 
> to work fine because I always test for equality to 0). If anyone has a cleaner 
> idea, please tell me. 

Well it treats them as signed because your enum _is_ signed (it has a -1 value).
If the -1 value (inherit) can't be in the KPerDomainSettings class, maybe it shouldn't
be in the enums at all? I'm not sure how Inherit is used in fact....

> This patch is not intended to be included within KDE, and serves merely a 
> draft ready to be commented upon.

Sure, it'll have to wait for after 3.1 :)

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD4DBQE9xWyk72KcVAmwbhARAgMSAJiW2m66SLvpkZFgXUKOk8I7griyAJ0afJbv
3fPs8BzLwU8JgKlbsQuMNA==
=DZhd
-----END PGP SIGNATURE-----