[patch] for per-domain settings

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 03 November 2002 22:22, Leo Savernik wrote:
> Am Sonntag, 3. November 2002 19:36 schrieb David Faure:
> > On Sunday 20 October 2002 22:01, Leo Savernik wrote:
> > > http://bugs.kde.org/attachment.cgi?id=229&action=view
> > > first patch, khtml side only
> >
> > Looks quite good to me.
> >
> > Note that you can use k_funcinfo instead of __PRETTY_FUNCTION__, it's
> > the portable version of it.
> 
> Thanks, I didn't know about k_funcinfo. But I intend to remove all those debug 
> outputs in the final version nonetheless.

They can help debugging further problems with the code, so I usually leave
them, but commented out :)

> > Well it treats them as signed because your enum _is_ signed (it has a -1
> > value). If the -1 value (inherit) can't be in the KPerDomainSettings class,
> > maybe it shouldn't be in the enums at all? I'm not sure how Inherit is used
> > in fact....
> 
> Inherit isn't used by anything within khtml, but it'll be needed by the 
> kcontrol module (which I haven't even started yet). Coincidentally I'm 
> adapting my old patch to the latest CVS, so I'll test if I get an unsigned 
> enum by setting Inherit to 32767 (this is guaranteed to be positive, even for 
> a 16 bit integer ;-) )

Hmm I would use something like a -1 value (e.g. static const int) in the 
kcontrol module. If it's not needed in khtml, better not have it there :)

> Btw, do you know how I can become the owner of bug 49145? I mean I *am* 
> effectively the owner, but bugs.kde.org doesn't reflect this, and I cannot 
> set myself to the owner.

"owner" is "initial owner", you can't change that. I have given your bugzilla user
more permissions, now you can assign the bug to yourself, hopefully.
 
> PS: no need to cc me, I'm subscribed to kfm-devel

Ok - just wanted to make sure you'd see the post, after so much time :}

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9xaHE72KcVAmwbhARAgHoAJ0WAyCaJ4BkW1Qj98TbCfvLONIatgCdGZgr
nUuIaFnASL6hkJLPxscNycM=
=C19e
-----END PGP SIGNATURE-----