action for LMB click in Konqueror

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 29 July 2002 22:40, Germain Garand wrote:
> Le Lundi 29 Juillet 2002 15:19, David Faure a écrit :
> > > That is IMHO, very bad policy... unless my KFM settings displays
> > > /usr/bin/sh as the preferred application in "General", I see no good
> > > reason why a shell script (which is rather, intrinsically, a document...)
> > > should run by itself ?
> >
> > Well, what happens when clicking on an executable? (in any desktop you can
> > think of, including Mac and Windows?)
> >
> > shellscripts are only one kind of executables.
> 
> You mean : if they have the +x mode ?
Yes (you're right).

> The problem is their dual nature turn them into Shröninger's Cat objects...
> One might not know when one click them wether they are executables or not..
Right... maybe we need a different icon for "executable shellscript"
and "non-executable shellscript" ?

> For the moment, the code only checks the service type to see if it belong to 
> the "might be" executable category, but it knows nothing about the actual 
> status of the file.
> There are some hacks to specifically allow x-shellscript to run, but it does 
> not solve the overall problem of isTextExecutable( services).
>
> > (the other mail about the +x bit sounds like a bug though. We detect the
> > application/x-shellscript from the content, and then test for that...
> > I suggest testing for the file permissions in kdelibs/kio/kio/krun.cpp:86
> > (sorry, no time for doing all the changes people talk about, so I just give
> > hints ;)
> 
> I didn't had much time today, but I'll work on a patch... may I ?

Sure ;-) 

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice 1.2 RC1 is slightly delayed. Stay tuned.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9RarT72KcVAmwbhARAnYJAJ9X8VwI+ViwzJBjhxXvtYSXu6M3RACfdihO
knP6Om4Lz3Lu9cqeQR1UIxo=
=V7GC
-----END PGP SIGNATURE-----