MMB opens in new tab

[David Faure]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 29 July 2002 05:44, Germain Garand wrote:
> Hi,
> I've just rebuilt and I'm seeing that too..
> 
> konqueror: KonqRun::foundMimeType text/plain
> konqueror: ------------- KonqViewManager::addTab starting -------------
> konqueror: 1Views
> konqueror: 0x81d9770
> konqueror: currentView=0x81d9770
> konqueror: docContainer=0x81d5064
> konqueror: KonqFrame [KonqFrame pointer (0x81d4ff0) to widget KonqFrame, 
> geometry=700x396+0+83] visble=1 containing view 0x81d9770 visble=1 and part 
> 0x82fc778 whose widget is a KHTMLView
> konqueror: KonqViewManager::createView
> konqueror: Trying to create view for "text/plain"
> konqueror: KonqFMSettings says: don't embed this servicetype

Seems wrong, that addTab would query the embedding settings, it should always embed ;)

Question to Doug: why does addTab() have a bool forceAutoEmbed parameter?
I think it should always pass true to createView, instead of that bool, so that
embedding always happens.

(if anyone wants to test: I'm talking about KonqViewManager::addTab, the createView()
call on line 366 in konq_viewmgr.cc)

- -- 
David FAURE, david at mandrakesoft.com, faure at kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice 1.2 RC1 is slightly delayed. Stay tuned.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9RO+C72KcVAmwbhARAp8xAKCM93CV5z6NSAWb9EEIni1xNJkvegCfXwdV
xraFC4zBbs/kAHj3J4RkcKM=
=kqSQ
-----END PGP SIGNATURE-----