[Kexi-devel] Fwd: Review Request 121655: Add overloads (non-raw queries and params) for convenience KexiDB functions

[Jaroslaw Staniek]

​Hi,​
This blocks Roman's https://git.reviewboard.kde.org/r/121443/ so please
review, thanks.

---------- Forwarded message ----------
From: Jarosław Staniek <staniek at kde.org>
Date: 23 December 2014 at 22:50
Subject: Review Request 121655: Add overloads (non-raw queries and params)
for convenience KexiDB functions
To: Wojciech Kosowicz <pcellix at gmail.com>, Andrius da Costa Ribas <
andriusmao at gmail.com>, Adam Pigg <adam at piggz.co.uk>, Radosław Wicik <
radoslaw at wicik.pl>, Roman Shtemberko <shtemberko at gmail.com>
Cc: Calligra <calligra-devel at kde.org>, Jarosław Staniek <staniek at kde.org>


   This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121655/
  Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Roman
Shtemberko, Radosław Wicik, and Wojciech Kosowicz.
By Jarosław Staniek.
 *Repository: * calligra
Description

Add overloads (non-raw queries and params) for convenience KexiDB functions

For:
- Utils::rowCount()
- Connection::querySingleRecord()
- Connection::querySingleString()
- Connection::querySingleNumber()
- Connection::queryStringList()

By the way, remove unsafe use of static variables in querySingleNumber().

Needed to fix the "Can't export data for parametrized query to a .csv
file" bug (151504)
see https://git.reviewboard.kde.org/r/121443/

  Testing

Tested with large .kexi files; these methods are used there and Kexi
still works OK

  Diffs

   - libs/db/connection.h (0ed171d857b93060398787226698b3c67758b024)
   - libs/db/connection.cpp (c422f78ca0f6c8a5f767e6892d0468821cccc567)
   - libs/db/utils.h (9bea691a4af95447983ddc0f093c1ae4b4aeb7e6)
   - libs/db/utils.cpp (923a401f7f4265d19c699db3d35046f21914747f)

View Diff <https://git.reviewboard.kde.org/r/121655/diff/>



-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kexi-devel/attachments/20141223/796707c2/attachment.html>