<div dir="ltr"><div class="gmail_default" style="font-family:courier new,monospace;font-size:large">Hi,</div><div class="gmail_default" style="font-family:courier new,monospace;font-size:large"></div><div class="gmail_default" style="font-family:courier new,monospace;font-size:large">This blocks Roman's <a href="https://git.reviewboard.kde.org/r/121443/">https://git.reviewboard.kde.org/r/121443/</a> so please review, thanks.<br><br></div><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Jarosław Staniek</b> <span dir="ltr"><<a href="mailto:staniek@kde.org">staniek@kde.org</a>></span><br>Date: 23 December 2014 at 22:50<br>Subject: Review Request 121655: Add overloads (non-raw queries and params) for convenience KexiDB functions<br>To: Wojciech Kosowicz <<a href="mailto:pcellix@gmail.com">pcellix@gmail.com</a>>, Andrius da Costa Ribas <<a href="mailto:andriusmao@gmail.com">andriusmao@gmail.com</a>>, Adam Pigg <<a href="mailto:adam@piggz.co.uk">adam@piggz.co.uk</a>>, Radosław Wicik <<a href="mailto:radoslaw@wicik.pl">radoslaw@wicik.pl</a>>, Roman Shtemberko <<a href="mailto:shtemberko@gmail.com">shtemberko@gmail.com</a>><br>Cc: Calligra <<a href="mailto:calligra-devel@kde.org">calligra-devel@kde.org</a>>, Jarosław Staniek <<a href="mailto:staniek@kde.org">staniek@kde.org</a>><br><br><br>
<div>
<div style="font-family:Verdana,Arial,Helvetica,sans-serif">
<table style="border:1px solid rgb(201,195,153);border-radius:6px" bgcolor="#f9f3c9" width="100%" cellpadding="12">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121655/" target="_blank">https://git.reviewboard.kde.org/r/121655/</a>
</td>
</tr>
</tbody></table>
<br>
<table style="border:1px solid rgb(136,138,133);border-radius:6px" bgcolor="#fefadf" width="100%" cellpadding="12" cellspacing="0">
<tbody><tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>
<div style="margin-top:1.5em">
<b style="color:rgb(87,80,18);font-size:10pt">Repository: </b>
calligra
</div>
<h1 style="color:rgb(87,80,18);font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid rgb(184,181,160)" bgcolor="#ffffff" width="100%" cellpadding="10" cellspacing="0">
<tbody><tr>
<td>
<pre style="margin:0px;padding:0px;white-space:pre-wrap;word-wrap:break-word"><p style="padding:0px;margin:0px;line-height:inherit;white-space:inherit">Add overloads (non-raw queries and params) for convenience KexiDB functions</p>
<p style="padding:0px;margin:0px;line-height:inherit;white-space:inherit">For:
- Utils::rowCount()
- Connection::querySingleRecord()
- Connection::querySingleString()
- Connection::querySingleNumber()
- Connection::queryStringList()</p>
<p style="padding:0px;margin:0px;line-height:inherit;white-space:inherit">By the way, remove unsafe use of static variables in querySingleNumber().</p>
<p style="padding:0px;margin:0px;line-height:inherit;white-space:inherit">Needed to fix the "Can't export data for parametrized query to a .csv file" bug (151504)
see <a href="https://git.reviewboard.kde.org/r/121443/" target="_blank">https://git.reviewboard.kde.org/r/121443/</a></p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:rgb(87,80,18);font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid rgb(184,181,160)" bgcolor="#ffffff" width="100%" cellpadding="10" cellspacing="0">
<tbody><tr>
<td>
<pre style="margin:0px;padding:0px;white-space:pre-wrap;word-wrap:break-word"><p style="padding:0px;margin:0px;line-height:inherit;white-space:inherit">Tested with large .kexi files; these methods are used there and Kexi still works OK</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:rgb(87,80,18);font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0px">
<li>libs/db/connection.h <span style="color:grey">(0ed171d857b93060398787226698b3c67758b024)</span></li>
<li>libs/db/connection.cpp <span style="color:grey">(c422f78ca0f6c8a5f767e6892d0468821cccc567)</span></li>
<li>libs/db/utils.h <span style="color:grey">(9bea691a4af95447983ddc0f093c1ae4b4aeb7e6)</span></li>
<li>libs/db/utils.cpp <span style="color:grey">(923a401f7f4265d19c699db3d35046f21914747f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121655/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
</div><br><br clear="all"><br>-- <br><div class="gmail_signature">regards, Jaroslaw Staniek<br><br>KDE:<br>: A world-wide network of software engineers, artists, writers, translators<br>: and facilitators committed to Free Software development - <a href="http://kde.org" target="_blank">http://kde.org</a><br>Calligra Suite:<br>: A graphic art and office suite - <a href="http://calligra.org" target="_blank">http://calligra.org</a><br>Kexi:<br>: A visual database apps builder - <a href="http://calligra.org/kexi" target="_blank">http://calligra.org/kexi</a><br>Qt Certified Specialist:<br>: <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/jstaniek</a></div>
</div>