D21156: Fix browse mode not disabled after Ctrl is released

[Simone Gaiarin]

simgunz added a comment.


  >> Wouldn't make more sense to do `arc land --onto 5.3` (and then merge 5.3 into master)? In this way the Differential Revision would be closed automatically.
  > 
  > I suggest to do a `arc amend` (to basically update the commit message with current reviewers, "Differentiatl Revision" line, etc.) and then `git push` your change manually to the right branch. Let's you use your normal git command-line to actually push changes, which to me is a much more thrust-worthy approach than to rely on arc to do that for me...
  
  Probably this should be added to the guide. And probably it should also be added that the commits should be squashed (thing that `arc land` does automatically).
  
  >> Wouldn't make more sense to do `arc land --onto 5.3` (and then merge 5.3 into master)? In this way the Differential Revision would be closed automatically.
  > 
  > IMHO yes, it would. I use it all the time :) Never failed to me. Only failed myself when forgetting to use --onto :)
  
  Good to know. I prefer this approach, seems way easier and less error prone than cherry pick, squash, arc amend and push.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D21156

To: simgunz, #kdevelop, rjvbb, mwolff
Cc: kossebau, kfunk, aacid, kde-doc-english, mwolff, rjvbb, kdevelop-devel, hmitonneau, christiant, gennad, fbampaloukas, glebaccon, domson, antismap, iodelay, alexeymin, skadinna, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190626/f697d110/attachment.html>