D22424: TextDocument: remove actions from contextmenu on hide already

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D22424#497271 <https://phabricator.kde.org/D22424#497271>, @rjvbb wrote:
  
  > >   The other option would have been to release 5.3.3 without a fix for ctags plugin users, rendering it unusable for people relying on packaged kdevelop. 
  >
  > Erm, aren't you forgetting about my patch which could have been applied to the (EOL!) 5.3 branch? That does the job just as well and would have left time to find a fix for #409858 in time for the next release.
  
  
  Please read the email behind the link I gave in my last comment (https://mail.kde.org/pipermail/kdevelop-devel/2019-July/063157.html), I did not forget about it and explicitly considered it.
  
  >>   >  But you might mean some other glitch, which I have no idea right now?
  > 
  > No, that glitch, which for me is just as unacceptable as the glitch your patch fixes. I get it systematically.
  
  As my comment should have made clear, but perhaps was not, that very glitch is unrelated to this very patch. It can be observed without the patch applied, and the origin of the logs appearing have been roughly described in the bug created and linked.
  
  >>   > FWIW I got to look at the KTE implementation of the context menu mechanism that is used here. It indeed uses and reuses a single QMenu instance (there's even a comment in the code about that).
  >>   
  >>   Please give links into the code, as I am lost what you exactly refer to here.
  > 
  > see the source of `KTextEditor::ViewPrivate::contextMenu()`. The ctx menu is in fact managed by KXMLGUI.
  
  The context menu is queried every time from KXMLGUI that method is called.  So  if KXMLGUI internally decides to recreate the context menu, you get another object the next time. Please see again the description of this very bug.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D22424

To: kossebau, #kdevelop
Cc: anthonyfieroni, rjvbb, kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190718/9050a9b8/attachment.html>