D15530: kdev-clang : somewhat more complete ObjC(++) support

[Aaron Puchert]

aaronpuchert added a comment.


  You should probably also add a few lines to the `custom-definesandincludes` plugin.

INLINE COMMENTS

> parsesession.cpp:112-113
> +        objcOption = QByteArrayLiteral("-xobjective-c++");
> +    } else if (parserSettings.parserOptions.isEmpty()) {
>          // The parserOptions can be empty for some unit tests that use ParseSession directly
>          auto defaultArguments = ClangSettingsManager::self()->parserSettings(path).toClangAPI();

This seems to be relevant for unit tests, why do you do the distinction here? I think it should be done down where my other comment is.

> parsesession.cpp:137-141
> +    if (!objcOption.isEmpty()) {
> +       result.append(objcOption);
> +    } else {
> +       result.append(parserSettings.isCpp() ? QByteArrayLiteral("-xc++") : QByteArrayLiteral("-xc"));
> +    }

Maybe the time has come to make this a `switch` statement.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D15530

To: rjvbb, #kdevelop
Cc: aaronpuchert, kossebau, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20180921/20b761f1/attachment.html>